Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public update state functions #10

Merged
merged 16 commits into from
Jul 24, 2024
Merged

Conversation

Ethanol48
Copy link
Contributor

@Ethanol48 Ethanol48 commented Jul 20, 2024

Motivation

In issue #6 was requested a public API for changing the state of the database,

Solution

Functions were implemented in SharedBackend and required some changes to the BackendHandler in order to implement the database changes. There's no breaking changes, but some edge cases must be tested.

There are some test to be written, like using a cache file, in the coming days I'll come up with a solution.

PR Checklist

  • Added Tests
  • Added Documentation

No Breaking changes

@Ethanol48 Ethanol48 marked this pull request as draft July 20, 2024 12:48
@Ethanol48
Copy link
Contributor Author

Changing the CHANGELOG.md is pending.

@Ethanol48
Copy link
Contributor Author

Test involving a chache file is pending.

@Ethanol48 Ethanol48 marked this pull request as ready for review July 21, 2024 15:55
@Ethanol48
Copy link
Contributor Author

I'm having a problem with git cliff, I can't manage to have a different tag, is my first time using this tool, if someone could give me it would be great.

@Ethanol48 Ethanol48 changed the title Public update state functions (draft) Public update state functions Jul 21, 2024
@mattsse
Copy link
Member

mattsse commented Jul 22, 2024

changelog is updated automatically, no need to update it

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I like this.

please add some docs, then this is complete

Cargo.toml Outdated Show resolved Hide resolved
@mattsse mattsse merged commit 596d267 into foundry-rs:main Jul 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants