Add flush to arbitrary file #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added minimal documentation. |
|
Pending changing to |
Ethanol48
changed the title
|
I’m sorry for any notifications sent, I was using my phone and the application doesn’t have much support and made some mistakes, my apologies. |
Ethanol48
changed the title
mattsse
requested changes
Jul 22, 2024
|
Done 👍🏼 |
DaniPopes
requested changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In issue #6 was discussed of adding public functions to change state in the db, and because of this I think it makes sense to have a way to have a cache file without the need to set it in the
db#11 , or in the case that we want to preserve the cache from the previous session without being altered.Solution
Added in
flush_to(cache_path)JsonBlockCacheDBimplementation a function that lets you dump the db in a determined file.