replace bounded channel with unbounded channel #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Aug 9, 2024
src/backend.rs
Outdated
Comment on lines
53
to
57
| type AccountInfoSender = UnboundedSender<DatabaseResult<AccountInfo>>; | ||
| type StorageSender = UnboundedSender<DatabaseResult<U256>>; | ||
| type BlockHashSender = UnboundedSender<DatabaseResult<B256>>; | ||
| type FullBlockSender = UnboundedSender<DatabaseResult<Block>>; | ||
| type TransactionSender = UnboundedSender<DatabaseResult<WithOtherFields<Transaction>>>; |
There was a problem hiding this comment.
ah sorry, perhaps I wasn't clear enough on the issue, these oneshots are fine and we should keep using oneshot here,
the channel that we want to convert is this one
foundry-fork-db/src/backend.rs
Line 649 in 40445d9
foundry-fork-db/src/backend.rs
Lines 572 to 573 in 40445d9
There was a problem hiding this comment.
It's my own fault. Your instruction is very clear. I need to dive into details. Thanks for your guiding. PTAL.
DaniPopes
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #14
Solution
PR Checklist