Bump alloy [provider, rpc-types, serde, transport, rpc-client, transp… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort-http] to 0.1.4, alloy-primitives to 0.7.7 and revm to 11.0.0
mattsse
requested changes
Jul 13, 2024
Cargo.toml
Outdated
Comment on lines
28
to
31
| alloy-provider = {version = "0.1.4", default-features = false} | ||
| alloy-rpc-types = {version = "0.1.4", features = ["eth"]} | ||
| alloy-serde = {version = "0.1.4", default-features = false} | ||
| alloy-transport = {version = "0.1.4", default-features = false} |
There was a problem hiding this comment.
I'm being very pedantic here but please keep the surrounding white space i {}
There was a problem hiding this comment.
Fixed all the white spaces my Code ate :)
mattsse
requested changes
Jul 13, 2024
src/backend.rs
Outdated
Comment on lines
691
to
693
| if number > u64::MAX { | ||
| return Ok(KECCAK_EMPTY); | ||
| } |
There was a problem hiding this comment.
this check is now redundant and can be removed entirely
There was a problem hiding this comment.
Completely missed that
Fixed
mattsse
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ort-http] to 0.1.4, alloy-primitives to 0.7.7 and revm to 11.0.0
Motivation
Solution
PR Checklist