-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing
): decode non-mainnet precompiles when tracing
#1078
Comments
Avalanche subnets that use the evm have these precompiles
More details on the interfaces are here |
we can integrate them,
|
@avaxmoon do you mind also leaving a comment on foundry-rs/forge-std#134 with the list of relevant avalanche precompiles + what chain IDs they apply to + links to docs? That way we remember to include them there when implementing that |
Celo has a bunch of extra precompiles here: https://github.com/celo-org/celo-blockchain/blob/91993404cdf69ff4dad810bae8ac02763ae667d8/core/vm/contracts.go#L168-L199 |
thanks for linking this. It would help if you could prepare them as address + signature pairs, this would make it easier to integrate them in the codebase. |
JFYI there's a Celo-specific Foundry fork that devs on Celo are using right now: |
Hi @mattsse 👋 @douglasqian kindly pointed me to this Github discussion. We'd love Celo to be fully compatible with Foundry out of the box 🙌 Regarding your comment above:
I put together a gist (Adding Celo to Foundry) with key information (mainly for future reference on our side) and @palango (from the Celo blockchain team) kindly provided a small sample of address + signature pairs to verify the format suits you. I copied the sample below for ease of reference
My question: How does the above look to you? (i.e. would this format make the integration easier for you?) |
Let's move the conversation to bluealloy/revm#280. Most of these precompiles are stateful, so would like to understand how you are thinking about introducing that state, e.g. https://github.com/bluealloy/revm/blob/main/crates/revm_precompiles/src/lib.rs#L58 |
Just noting that one other part of compatibility would be to update |
Will there be anything else needed besides the changes in |
tracing
): decode non-Ethereum precompiles when tracing
tracing
): decode non-Ethereum precompiles when tracingtracing
): decode non-mainnet precompiles when tracing
Right now we only decode the Ethereum precompiles when tracing, we should add some way to decode extra precompiles. What are some example precomppiles from other networks?
Originally posted by @mattsse in #1067 (comment)
The text was updated successfully, but these errors were encountered: