expectCall cheatcode overloaded with msg.value assertion

[tynes]

Component

Forge

Describe the feature you would like

Currently vm.expectCall operates on a target address and the calldata it expects

 function expectCall(address,bytes calldata) external;

When sending ETH through multiple contracts, it would be useful to have an overloaded expectCall that also accepts a value param that also asserts on call context's value (msg.value)

function expectCall(address,uint256 value,bytes calldata) external;

Didn't see this mentioned in any open issues, including #876

Additional context

No response

[AdithyaNarayan]

Is this issue available? I would like to work on this as my first PR

[tynes]

I think overloading mockCall in the same way would be useful too.

Definitely feel free to open a PR, I don't know of anybody working on this now.

[AdithyaNarayan]

While overloading mockCall, I came across bug #1604. Is it ok if I do one PR to fix both of them? (Since #1604 is a one-line fix)

[AdithyaNarayan]

Quick question, for the mockCall overload, which would take precedence, msg.value, or calldata?

vm.mockCall(address(target), 10, abi.encodeWithSelector(target.f.selector), abi.encode(10));
vm.mockCall(address(target), abi.encodeWithSelector(target.f.selector, 1), abi.encode(20));

assertEq(target.f{value: 10}(1) == ???);

What is the expected return data in this case?