Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge create / cast send): add --gas-estimate-multiplier flag #1803

Open
mattsse opened this issue Jun 1, 2022 · 3 comments
Open

feat(forge create / cast send): add --gas-estimate-multiplier flag #1803

mattsse opened this issue Jun 1, 2022 · 3 comments
Labels
C-cast Command: cast C-forge Command: forge Cmd-forge-create Command: forge create good first issue Good for newcomers P-normal Priority: normal T-feature Type: feature

Comments

@mattsse
Copy link
Member

mattsse commented Jun 1, 2022 •
edited
Loading

Component

Forge

Describe the feature you would like

For certain networks, gas(price) may be incorrectly estimated, resulting in transactions that are underpriced:

#1703

in forge create we use the default Provider::{estimate_gas,get_gas_price} functions to fill the transactions, if they're not provided via cli arguments

it would be useful to scale these estimates percentage-wise, perhaps --scale-gas-limit 20 to use a 1.2 multiplier for the gas limit.

Additional context

No response
@mattsse mattsse added good first issue Good for newcomers T-feature Type: feature C-forge Command: forge D-easy Difficulty: easy labels Jun 1, 2022
@onbjerg onbjerg added this to Foundry Jun 1, 2022
@onbjerg onbjerg moved this to Todo in Foundry Jun 1, 2022
@shawnharmsen
Copy link
Contributor

I'd like to take a stab at this, will update with pr soon

@mattsse
Copy link
Member Author

mattsse commented Jun 6, 2022

awesome! keep 'em coming!

@shawnharmsen shawnharmsen mentioned this issue Jun 13, 2022
Closed
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@zerosnacks zerosnacks changed the title Support scaling gas related arguments feat(forge create / script): support applying a scalar to gas related arguments Aug 1, 2024
@zerosnacks zerosnacks added Cmd-forge-create Command: forge create Cmd-forge-script Command: forge script labels Aug 1, 2024
@zerosnacks zerosnacks changed the title feat(forge create / script): support applying a scalar to gas related arguments feat(forge create / cast send): add --gas-estimate-multiplier Aug 1, 2024
@zerosnacks zerosnacks mentioned this issue Aug 1, 2024
Open
@zerosnacks zerosnacks added C-cast Command: cast and removed Cmd-forge-script Command: forge script labels Aug 1, 2024
@zerosnacks
Copy link
Member

Note for future reference: forge script implements this functionality under the --gas-estimate-multiplier flag, the goal of the ticket would be to implement this for cast send and forge create.

@zerosnacks zerosnacks changed the title feat(forge create / cast send): add --gas-estimate-multiplier feat(forge create / cast send): add --gas-estimate-multiplier flag Aug 1, 2024
@zerosnacks zerosnacks removed the D-easy Difficulty: easy label Aug 1, 2024
@zerosnacks zerosnacks added the P-normal Priority: normal label Sep 11, 2024
@grandizzy grandizzy removed this from the v1.0.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cast Command: cast C-forge Command: forge Cmd-forge-create Command: forge create good first issue Good for newcomers P-normal Priority: normal T-feature Type: feature
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(forge): create add scale-gas-limit shawnharmsen/foundry
4 participants
@shawnharmsen @mattsse @grandizzy @zerosnacks