Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC cache possibly flaky since #1715 #2383

Closed
2 tasks
mattsse opened this issue Jul 19, 2022 · 1 comment · Fixed by #2385
Closed
2 tasks

RPC cache possibly flaky since #1715 #2383

mattsse opened this issue Jul 19, 2022 · 1 comment · Fixed by #2385
Assignees
@mattsse
Labels
C-forge Command: forge Cmd-forge-script Command: forge script Cmd-forge-test Command: forge test T-bug Type: bug
Milestone
v1.0.0

Comments

@mattsse
Copy link
Member

mattsse commented Jul 19, 2022

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

No response

Operating System

No response

Describe the bug

getting some reports that rpc cache no longer works

likely due to changes made in #1715

ref #2366
@mattsse mattsse added the T-bug Type: bug label Jul 19, 2022
@mattsse mattsse self-assigned this Jul 19, 2022
@gakonst gakonst added this to Foundry Jul 19, 2022
@gakonst gakonst moved this to Todo in Foundry Jul 19, 2022
@meetmangukiya
Copy link
Contributor

Just ended up looking into this #2384 😅

@meetmangukiya meetmangukiya mentioned this issue Jul 19, 2022
Closed
@mattsse mattsse mentioned this issue Jul 19, 2022
Merged
@onbjerg onbjerg added this to the v1.0.0 milestone Jul 19, 2022
@onbjerg onbjerg added Cmd-forge-test Command: forge test C-forge Command: forge Cmd-forge-script Command: forge script labels Jul 19, 2022
@onbjerg onbjerg moved this from Todo to In Progress in Foundry Jul 19, 2022
Repository owner moved this from In Progress to Done in Foundry Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
C-forge Command: forge Cmd-forge-script Command: forge script Cmd-forge-test Command: forge test T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix: properly enable storage caching mattsse/foundry
3 participants
@meetmangukiya @onbjerg @mattsse