Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anvil should gracefully deal with the upstream fork rate limits #4894

Closed
Tracked by #8269
miohtama opened this issue May 8, 2023 · 2 comments · Fixed by alloy-rs/alloy#1373
Closed
Tracked by #8269

Anvil should gracefully deal with the upstream fork rate limits #4894

miohtama opened this issue May 8, 2023 · 2 comments · Fixed by alloy-rs/alloy#1373
Labels
A-compatibility Area: compatibility C-anvil Command: anvil T-feature Type: feature
Milestone

Comments

@miohtama
Copy link

miohtama commented May 8, 2023

Component

Anvil

Describe the feature you would like

Currently, when using Anvil with quicknode.com hard fork Anvil may crash:

stderr: thread 'main' panicked at 'Failed to get fork block number: JsonRpcClientError(SerdeJson { err: Error("unknown field `code, expected one of id, jsonrpc, result, error, params, method`", line: 1, column: 7), text: "{\"code\":-32007,\"message\":\"100/second request limit reached - reduce calls per second or upgrade your account at quicknode.com\"}" })', /home/runner/work/foundry/foundry/anvil/src/config.rs:816:30

Additional context

This could be dealt with

  • Anvil allowing to set the rate limit to the upstream, e.g. by a command line option --force-rate-limit 100/s
  • Correctly throttle on Quicknode.com error if should throttling logic already exists in Anvil, instead of panic
@miohtama miohtama added the T-feature Type: feature label May 8, 2023
@miohtama miohtama changed the title Anvil should gracefully deal with the upstream fork ratelimits Anvil should gracefully deal with the upstream fork rate limits May 8, 2023
@gakonst gakonst added this to Foundry May 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry May 8, 2023
@zerosnacks zerosnacks added C-anvil Command: anvil A-compatibility Area: compatibility labels Jun 27, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@grandizzy
Copy link
Collaborator

@miohtama there was a PR merged with quicknode retry improvements, can you check if panic is still reproducible with latest anvil? thank you

@mattsse
Copy link
Member

mattsse commented Sep 26, 2024

@grandizzy this issue is outdated and can be closed, added test for good measure

@mattsse mattsse closed this as completed Sep 26, 2024
@jenpaff jenpaff moved this from Todo to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: compatibility C-anvil Command: anvil T-feature Type: feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants