Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge fails due to gasstation used to get fees for Polygon mainnet being down #5167

Closed
2 tasks done
dontrolle opened this issue Jun 16, 2023 · 3 comments · Fixed by gakonst/ethers-rs#2479
Closed
2 tasks done
Labels
T-bug Type: bug

Comments

@dontrolle
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (fca0a6c 2023-06-16T00:08:10.030703163Z)

What command(s) is the bug in?

forge script

Operating System

Linux

Describe the bug

Note: We've encountered this bug in our CI pipeline run on a fairly standard GitHub Actions setup (cf. https://github.com/mangrovedao/mangrove-bots/actions/runs/5276245102/jobs/9571216174, if interested).

Bug

forge script fails when deploying to (a local fork of) Polygon mainnet - seemingly due to https://gasstation-mainnet.matic.network/v2 being used to get gas-fees (I assume due to the long-standing Polygon/ethers.js fee-issue, cf ethers-io/ethers.js#2828). This gasstation has recently (this week) stopped being available.

We are ourselves in the middle of switching over to https://gasstation.polygon.technology/v2 for gas-fee estimation for Polygon mainnet.

Without having dug deeply in the underlying code for forge, I assume that forge may need to do something similar.

@dontrolle dontrolle added the T-bug Type: bug label Jun 16, 2023
@dontrolle
Copy link
Author

PS adding the --legacy option to the forge script command does seem to alleviate the problem, so for now, we're using that to unblock our CI pipelines.

@DaniPopes
Copy link
Member

@Evalir closeable

@Evalir
Copy link
Member

Evalir commented Jun 19, 2023

Closing as we recently merged #5180 — thanks @DaniPopes 👑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants