Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forge): make --priority-gas-price available in forge script #5281

Closed
PaulRBerg opened this issue Jul 3, 2023 · 8 comments · Fixed by #5585
Closed

feat(forge): make --priority-gas-price available in forge script #5281

PaulRBerg opened this issue Jul 3, 2023 · 8 comments · Fixed by #5585
Assignees
Labels
T-feature Type: feature

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Jul 3, 2023

Component

Forge

Describe the feature you would like

The --priority-gas-price flag seems to be available only for the forge create command:

https://book.getfoundry.sh/reference/forge/forge-create?highlight=priority#options

Running forge script --help does not list this flag:

https://app.warp.dev/block/8XMHLZq19VYER8fe5XpURz

Additional context

Output of forge --version:

9aefa43 2023-07-03T00:07:40.921128000Z
@PaulRBerg PaulRBerg added the T-feature Type: feature label Jul 3, 2023
@gakonst gakonst added this to Foundry Jul 3, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jul 3, 2023
@Evalir Evalir self-assigned this Jul 3, 2023
@ultrasecreth
Copy link

+1, I think this is very important, I've been deploying some contracts to optimism, and the default 3 Gwei tip is many orders of magnitude higher than the gas price of about 60 Wei, so it costed me infinitely more.

@Sabnock01
Copy link
Contributor

Sabnock01 commented Aug 2, 2023

Do you mind if I take this one next week @Evalir ?

@Evalir
Copy link
Member

Evalir commented Aug 2, 2023

@Sabnock01 feel free to take this

@Evalir Evalir assigned Sabnock01 and unassigned Evalir Aug 2, 2023
@NavalRavikant
Copy link

I just wasted $200 deploying contracts because of same issue on BASE (optimism based).

This is really important. I'm forced to switch to Hardhat now until it's fixed.

@PaulRBerg
Copy link
Contributor Author

I just wasted $200 deploying contracts because of same issue on BASE

ditto

@ultrasecreth
Copy link

Yesterday deployed to Arbitrum, the hack for now is to use --legacy --with-gas-price, which in Arbitrum is easy cause it's almost always 0.1 gwei, OP chains vary more so its trickier, but prob worth it until @Sabnock01 free us from the pain :)

@mattsse
Copy link
Member

mattsse commented Aug 10, 2023

ah yikes

@Evalir let's fix this

@ultrasecreth
Copy link

ah yikes

@Evalir let's fix this

Also when you do so, pls pls make sure you look at the chain you're interacting with.
What I mean is that there's prob no reason to even set a tip on Optimism and Arbitrum, so the default should be zero for those chains (and any other fork/similar ones).

This should be a thing done across the board, to include cast send and others, surprisingly enough none of the big wallets seems to be handling this correctly, leading to what I believe is multi-million loses for the users of those L2s, let's not get foundry on the same bag pls :)

More info here: https://twitter.com/ultrasecreth/status/1687785758755622912?s=20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants