Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast returning 'illegal abi' error when sending transactions to functions with tuples #670

Closed
2 tasks done
sadministrator opened this issue Feb 4, 2022 · 1 comment · Fixed by #2151
Closed
2 tasks done
Assignees
Labels
C-cast Command: cast P-normal Priority: normal T-bug Type: bug

Comments

@sadministrator
Copy link

sadministrator commented Feb 4, 2022

Component

Cast, Other (please describe)

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.1.0 (0b6b202 2022-02-04T16:36:20.877746906+00:00)

What command(s) is the bug in?

forge send and possibly others

Operating System

Linux

Describe the bug

cast send used in format seth call [<options>] <to> <sig> [<args>...] does not correctly parse function signatures if they contain tuples. It seems this problem stems from the ethers-rs repo, specifically here.

It looks like line 261 in particular would be causing the issue since is splits the calldata arguments with '(' as the delimiter in order to separate input and output args, but that would break if there are any tuples present as args.

This issue is also present in seth, although the error message is a little clearer here as it outputs seth-abi: error: unexpected character "(" at position 0 in "(bytes1,bytes32,uint64)".

@sadministrator sadministrator added the T-bug Type: bug label Feb 4, 2022
@onbjerg onbjerg added C-cast Command: cast P-normal Priority: normal labels Feb 4, 2022
@onbjerg onbjerg added this to Foundry Apr 17, 2022
@onbjerg onbjerg moved this to Todo in Foundry Apr 17, 2022
@onbjerg onbjerg mentioned this issue Jun 20, 2022
2 tasks
@onbjerg
Copy link
Member

onbjerg commented Jun 24, 2022

@mattsse Assigning you to this since it's the same underlying issue as #2025 and you assigned yourself to that one

Repository owner moved this from Todo to Done in Foundry Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cast Command: cast P-normal Priority: normal T-bug Type: bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants