Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anvil test migration to alloy #7449

Closed
mattsse opened this issue Mar 19, 2024 · 4 comments · Fixed by #7701
Closed

anvil test migration to alloy #7449

mattsse opened this issue Mar 19, 2024 · 4 comments · Fixed by #7701
Assignees
Labels
T-feature Type: feature

Comments

@mattsse
Copy link
Member

mattsse commented Mar 19, 2024

Component

Anvil

Describe the feature you would like

anvil e2e tests are using ethers-providers, which can be fully migrated to foundry now:

these can be done iteratively, one file at a time so that we could work in tandem on this

the setup should be very similar to alloy-examples

cc @zerosnacks @yash-atreya

likely blocked until @klkvr cast migration pr lands that updates alloy

Unblocked

Additional context

No response

@mattsse mattsse added the T-feature Type: feature label Mar 19, 2024
@zerosnacks zerosnacks self-assigned this Mar 19, 2024
@zerosnacks
Copy link
Member

zerosnacks commented Mar 21, 2024

Possibly unblocked now that https://github.com/foundry-rs/foundry/pull/7425/files has been merged

Currently blocked to a degree by Foundry pinning to 9ac2c90

@zerosnacks
Copy link
Member

Related PR by @Evalir: #6960

@klkvr
Copy link
Member

klkvr commented Mar 25, 2024

@zerosnacks #7425 was merged into #7106 branch, this PR is blocked on it currently

@zerosnacks
Copy link
Member

Unblocked by merged #7106

Now ready to pick up

cc @yash-atreya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants