Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge test CI failed with error using latest night build #7620

Closed
2 tasks done
y77cao opened this issue Apr 10, 2024 · 4 comments · Fixed by #7638
Closed
2 tasks done

Forge test CI failed with error using latest night build #7620

y77cao opened this issue Apr 10, 2024 · 4 comments · Fixed by #7638
Labels
T-bug Type: bug

Comments

@y77cao
Copy link

y77cao commented Apr 10, 2024

Component

Foundryup

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

nightly-460319558e455611be1de64be8364c65c6896d15

What command(s) is the bug in?

forge test

Operating System

Linux

Describe the bug

Test CI suddenly fails today with error "max priority fee per gas higher than max fee per gas". Here's the setup:

    - name: Setup foundry
      uses: foundry-rs/foundry-toolchain@v1
      with:
        version: nightly

Tests run fine locally. And I was also able to fix the CI by using nightly-72bc4f4e616c6e2b79ee3582301fbb1d38660857 released 3 days ago. Maybe something off with the latest build?

@y77cao y77cao added the T-bug Type: bug label Apr 10, 2024
@Evalir
Copy link
Member

Evalir commented Apr 10, 2024

This seems related to #7106, but we really can't track this down without a repro—is it possible for you to provide one?

@yonadaaa
Copy link

yonadaaa commented Apr 10, 2024

@Evalir Can confirm this is also happening in MUD, tests pass locally but CI fails with "max priority fee per gas higher than max fee per gas".

It started a day or so ago and we are pinned to nightly Foundry.

Dummy PR with failed test runs: latticexyz/mud#2633
image

@y77cao
Copy link
Author

y77cao commented Apr 10, 2024

This seems related to #7106, but we really can't track this down without a repro—is it possible for you to provide one?

what @yonadaaa mentioned is accurate - I am also using MUD and this happens at running post deploy script. Here's the repro: https://github.com/y77cao/foundry-fail-ci-repro/actions/runs/8635980697/job/23674943465

@mattsse
Copy link
Member

mattsse commented Apr 10, 2024

@klkvr I wonder if this is an edge case in broadcast or an alloy send_transaction check is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants