Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cheatcodes): support native bound cheatcode #8788

Open
grandizzy opened this issue Sep 2, 2024 · 5 comments · May be fixed by #9154
Open

feat(cheatcodes): support native bound cheatcode #8788

grandizzy opened this issue Sep 2, 2024 · 5 comments · May be fixed by #9154
Assignees
Labels
A-cheatcodes Area: cheatcodes good first issue Good for newcomers T-feature Type: feature

Comments

@grandizzy
Copy link
Collaborator

grandizzy commented Sep 2, 2024

Component

Forge

Describe the feature you would like

see convo foundry-rs/forge-std#584 (comment)

Additional context

/// forge-config: default.fuzz.range.y = [1, 10];
function testFoo(uint256 x, uint256 y) public {

and pass the min / max bound values to UintStrategy/IntStrategy

  • tests should make sure that, if fuzzing over a large space, logarithmic uniformity is preferred, whereas if fuzzing a uint8 then standard uniform sampling is preferred
@grandizzy grandizzy added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Sep 2, 2024
@zerosnacks zerosnacks added A-cheatcodes Area: cheatcodes and removed T-needs-triage Type: this issue needs to be labelled labels Sep 2, 2024
@zerosnacks zerosnacks changed the title feat(cheatcodes): support native bound cheatcode feat(cheatcodes): support native bound cheatcode Sep 3, 2024
@zerosnacks zerosnacks added the good first issue Good for newcomers label Sep 3, 2024
@07Vaishnavi-Singh
Copy link

07Vaishnavi-Singh commented Sep 7, 2024

Hey I am working under WIEP (cohort 2 )and would like to work on this issue
I have understood the issue and maths involved in it
Would be great if u can assign me this issue :)
@zerosnacks @grandizzy

@07Vaishnavi-Singh
Copy link

Hey @zerosnacks , following the Contribution Guidlines when I am running cargo test --all --all-features there are 9 test cases failling in the original repo I forked and cloned n there are no additional test cases failling after adding boundLog that is required in this issue. Is there a problem in my project setting due to any dependency issue or should I just ignore these 9 failing test cases and make sure no additional test cases fail after adding the featire due to the newly added boundLog.
In case of incorrect project setup can you pls help to fix it.

@07Vaishnavi-Singh
Copy link

Hey, I got clarified about the above issue in the TG grp and run it locally for any additional Failing Testcases and the PR is ready to be reviewed.
Would be great if u can share your TG or X handle as that would help me close this issue earlier.

Thanks @grandizzy @zerosnacks

@malik672 malik672 linked a pull request Oct 21, 2024 that will close this issue
@malik672
Copy link
Contributor

malik672 commented Oct 22, 2024

can I get assigned to this @jenpaff

@jenpaff jenpaff assigned jenpaff and malik672 and unassigned jenpaff Oct 22, 2024
@jenpaff
Copy link
Collaborator

jenpaff commented Oct 22, 2024

can I get assigned to this @jenpaff

assigned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cheatcodes Area: cheatcodes good first issue Good for newcomers T-feature Type: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants