Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge compiles despite unresolved imports #9272

Open
2 tasks done
adhusson opened this issue Nov 6, 2024 · 3 comments · Fixed by #9274
Open
2 tasks done

forge compiles despite unresolved imports #9272

adhusson opened this issue Nov 6, 2024 · 3 comments · Fixed by #9274
Labels
A-compiler Area: compiler A-remappings Area: remappings P-high Priority: high T-bug Type: bug T-post-V1 Area: to tackle after V1

Comments

@adhusson
Copy link
Contributor

adhusson commented Nov 6, 2024 •
edited
Loading

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (57bb12e 2024-11-06T00:26:30.417023000Z)

What command(s) is the bug in?

forge build

Operating System

macOS (Apple Silicon)

Describe the bug

  1. Clone this repo
  2. forge build

Some imports will be noted as unresolved by forge, but compilation + tests will succeed.

May be related to #9271.
@adhusson adhusson added T-bug Type: bug T-needs-triage Type: this issue needs to be labelled labels Nov 6, 2024
@grandizzy grandizzy mentioned this issue Nov 6, 2024
Merged
@zerosnacks zerosnacks added A-remappings Area: remappings P-high Priority: high and removed T-needs-triage Type: this issue needs to be labelled labels Nov 6, 2024
@zerosnacks
Copy link
Member

cc @adhusson nightly has been released, please re-run foundryup

@grandizzy grandizzy mentioned this issue Nov 12, 2024
Open
2 tasks
@grandizzy
Copy link
Collaborator

reopen as this wasn't something related to the regression introduced, and still reproducible

@grandizzy grandizzy reopened this Nov 12, 2024
@grandizzy grandizzy added this to the v1.0.0 milestone Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 12, 2024
@grandizzy grandizzy added the A-compiler Area: compiler label Nov 12, 2024
@grandizzy grandizzy removed this from the v1.0.0 milestone Nov 14, 2024
@grandizzy grandizzy added the T-post-V1 Area: to tackle after V1 label Nov 14, 2024
@grandizzy
Copy link
Collaborator

grandizzy commented Nov 15, 2024 •
edited
Loading

this happens because of how imports recurse is handled - that is capped at project root

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiler Area: compiler A-remappings Area: remappings P-high Priority: high T-bug Type: bug T-post-V1 Area: to tackle after V1
Projects
Foundry
Archived in project
Milestone
No milestone
3 participants
@adhusson @grandizzy @zerosnacks