Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remappings for Contracts with Same Dependencies but different Paths #11

Open
rzmahmood opened this issue Aug 29, 2023 · 1 comment
Open

Comments

@rzmahmood
Copy link

One of my forge installed libraries uses this import path for it's OZ dependency:

import "@openzeppelin/contracts/token/ERC721/ERC721.sol";

Another one of the contracts from a different library uses this import path:

import "openzeppelin-contracts/contracts/access/AccessControl.sol";

My OZ dependency lives in lib/openzeppelin-contracts

My remappings are as such:

@openzeppelin=lib/openzeppelin-contracts/
openzeppelin-contracts/=lib/openzeppelin-contracts/

Unfortunately, the hardhat preprocess does a sed which means that it does the following:

  1. Replace @openzeppelin with lib/openzeppelin-contracts/
  2. Replace lib/openzeppelin-contracts/ with lib/lib/openzeppelin-contracts/

I was able to resolve the issue by changing the order of my remappings to avoid the overlap, but this issue may affect others

@mai1015
Copy link

mai1015 commented Dec 3, 2023

yep, i added line = line.replace("lib/lib", "lib") into hardhat config, that fix the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants