Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sncast account create should show copyable command for deployment #2667

Open
cptartur opened this issue Nov 12, 2024 · 2 comments
Open

sncast account create should show copyable command for deployment #2667

cptartur opened this issue Nov 12, 2024 · 2 comments
Labels
feature New feature request/description sncast

Comments

@cptartur
Copy link
Member

Which components does the task require to be changed? (think hard pls)

sncast

Description

Right now, when sncast account create is used, it is unclear how to deploy the created account.
The output already indicates that the account needs to be prefunded but doesn't show how to do so.

Change sncast account create output, so it also includes a ready to copy command for declaring. The arguments like --url that are provided by the user should be captured and included in the output command so it can be copied and run.

Concept:

$ sncast account create --url my_url.xyz --name my_account
add_profile: --add-profile flag was not set. No profile added to snfoundry.toml
address: 0x075c4094d5431fea3bdfa1c65d393ea52315f513b9fa81d1466edf1d91fc4022
max_fee: 4241681639235
message: Account successfully created. Prefund generated address with at least <max_fee> STRK tokens or an equivalent amount of ETH tokens. It is good to send more in the case of higher demand.

After prefunding the address run:
sncast account deploy --url my_url.xyz --name my_account --fee-token strk 
@cptartur cptartur added feature New feature request/description sncast labels Nov 12, 2024
@cptartur cptartur moved this to New in Starknet foundry Nov 12, 2024
@github-actions github-actions bot added the new label Nov 12, 2024
@ShantelPeters
Copy link

Please can I be assigned to this issue @cptartur

@cptartur cptartur removed the new label Nov 14, 2024
@cptartur
Copy link
Member Author

Hey, thanks for applying, however we mostly accept applications for tasks marked with "help wanted" or "good first issue" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request/description sncast
Projects
Status: Backlog
Development

No branches or pull requests

2 participants