Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cli::try_parse_from in cast docs snippets validation #2678

Open
franciszekjob opened this issue Nov 15, 2024 · 0 comments
Open

Use Cli::try_parse_from in cast docs snippets validation #2678

franciszekjob opened this issue Nov 15, 2024 · 0 comments

Comments

@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 15, 2024

Which components does the task require to be changed? (think hard pls)

sncast

Description

Currently, sncast docs snippets are validated only using runner. Before running the command, we should check if it's at least valid using try_parse_from on Cli. ATM, we cannot do this, because Cli cannot be imported from main.rs.

In the scope of this issue, we should move Cli from main.rs to lib.rs (and other needed structs/functions) and use Cli::try_parse_from before using runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

1 participant