Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate relay creation #42

Closed
elementbound opened this issue Aug 12, 2023 · 0 comments
Closed

Fix duplicate relay creation #42

elementbound opened this issue Aug 12, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@elementbound
Copy link

Background

During the connect-relay command, noray ensures both parties have a relay. In case they do, the relay is used as-is, otherwise ( e.g. never had a relay, or the one they had has expired ), a new one is created.

However, noray fails to recognize if a relay already exists for the given party, so it always creates a new one. This results in duplicate relays that also don't work - they are proxied, but traffic doesn't get through to the host ( possibly because of missing NAT entries ).

Done criteria

  • No duplicate relays are created
  • RelayEntry equality check is fixed
  • hasRelay tests are added
@elementbound elementbound added this to the v1.x milestone Aug 12, 2023
@elementbound elementbound added the bug Something isn't working label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant