-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building against integer-simple #147
Conversation
@@ -31,7 +31,9 @@ import Data.IntSet (IntSet) | |||
import qualified Data.List.NonEmpty as NE | |||
import Data.Map (Map) | |||
import Data.Monoid | |||
#if !MIN_VERSION_primitive(0,7,0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unrelated change to fix the build against newer versions of primitive
. It is still not sufficient to get the test suite working on recent GHCs and recent dependencies (I tried 8.6.5) so to test the instance, I’ve simply uncommented everything but Integer
in the “Store on all monomorphic instances” tests.
LGTM, thanks!! |
Note: I have some unpushed changes, fixing the other issues, that I will revisit later this evening |
@cocreature I've fixed building of the tests and added explicit unit tests for the serialization of I'd really appreciate it if you ran the tests with integer-simple. For some reason I can't seem to build the tests with the flag on, it seems to trigger a variety of different build tool issues:
¯\(ツ)/¯ Definitely have the flag and extra dep in the stack.yaml https://gist.github.com/mgsloan/d92ed7f28d19ebeb469fdb398a59efc0 |
@mgsloan Note that you need a different GHC bindist for integer-simple, I got mine via nix. I’ve run the tests (after constraining In principle it would be possible to match the serialization format of |
@cocreature Oh I see. I thought otherwise because this comment got copied when you wrote the integer-simple code:
I've pushed changes documenting this mismatch and removing the test |
…147 + remove tests for identical behavior
This change is included in 0.6.1, thanks! |
fixes #135