Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the reply has an e tag that doesn't match the current id of the replaceable event, display a notice #35

Closed
fiatjaf opened this issue Oct 14, 2023 · 6 comments

Comments

@fiatjaf
Copy link
Contributor

fiatjaf commented Oct 14, 2023

Pseudocode:

if root.kind > 10000 and current_reply.has_tag('e') and current_reply.get_tag('e') !== root.id:
    display_warning = True

Something like this (obviously just an idea):

2023-10-14-080204_653x298_scrot

I was trying to implement it, but I figured I would make a big mess in the code, so I decided to just open this issue instead.

@franzaps
Copy link
Owner

Yes, this was exactly my idea. I will implement it.

@franzaps
Copy link
Owner

Found an issue. A kind 1 event showed up with a single e tag and a single a tag.

Since the e tag value was an unknown event, I showed the warning notice (assuming this value could have been a replaced 30023 event).

It turns out that e tag value was a pointer to a highlight (kind 9802) that was not loaded, probably as it was outside of the current relay set.

We will likely encounter false positives like these. We need a different language than "in reply to a different version of this article" as that may simply not be true.

@fiatjaf
Copy link
Contributor Author

fiatjaf commented Oct 26, 2023

So someone made a highlight Y referencing an event X and someone replied to the highlight and included both X and Y as tags?

@franzaps
Copy link
Owner

@fiatjaf Yes, exactly. The e tag has no marker so it's difficult to say what it's referencing. The highlight eventually appeared so this stopped being a problem, but it could happen again

@franzaps
Copy link
Owner

franzaps commented Oct 27, 2023

I'm solving it like this for now:

These events do exist and are of type 9801. Who knows wth that kind is.

@franzaps
Copy link
Owner

Addressed and significantly improved in f82d58e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants