-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server does not remove unset optional task args values #196
Comments
I think we should modify the fractal-server task-parch endpoint, I'll open a more precise issue later. |
If we move on as in fractal-analytics-platform/fractal-server#758, then we should expect that the server deletes {
"args": {
"raise_error": true,
"message": "test"
}
} |
We now released fractal-server 1.3.0a9, and this is the correct behavior to expect. Note that for parameters that do have a default value in the args schema (which is not the case for |
Closed as of recent fractal-server update |
With the changes required by #190, the server will no longer receive payloads with properties that have
null
values.This will bing to the following scenario:
Given the following schema:
If an user sets, through the client by saving edits, the
sleep_time
property, then the server will receive the following HTTP request, with given payload.Upon following refresh of the page, the client will receive the same payload, saved before.
Let's assume that the user wants to remove the optional parameter
sleep_time
To do so, the user deletes from the UI the number inside the form and confirms to save changes.
The fractal server, after #190 will receive the following payload.
The user now expects that, upon refreshing the page, or upon running the task, the
sleep_time
property is not set.Instead, the server, will handle the client the following payload.
Shall we expect that the server deletes or sets the
sleep_time
property tonull
or deletes it? @tcompa @jluethiThe text was updated successfully, but these errors were encountered: