Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputing invalid Timeout param in HTTP client shards should result in error containing line/column info #850

Open
ccfontes opened this issue Oct 31, 2023 · 0 comments
Labels
low priority The importance of this task, is it blocking the users? High, is it just annoying a single user? Low. Type: Bug

Comments

@ccfontes
Copy link
Contributor

Describe the bug
If we set an invalid Timeout like this:

"foo" | Http.Delete("http://<url>", Timeout: -1) | Log

error thrown leaks Rust error message without .shs line/column info:

thread '<unnamed>' panicked at 'overflow when adding duration to instant', library/std/src/time.rs:408:33
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: Rust panics must be rethrown
zsh: abort      shards new test.shs

Issue affects other HTTP client method shards in the same way, namely:

  • Http.Post
  • Http.Put
  • Http.Patch
  • Http.Get
  • Http.Head

Expected behavior
Inputting invalid Timeout parameter to Http.Delete should result in error containing line/column info where the error occurs in the .shs script.

@ccfontes ccfontes added low priority The importance of this task, is it blocking the users? High, is it just annoying a single user? Low. Type: Bug labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority The importance of this task, is it blocking the users? High, is it just annoying a single user? Low. Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant