Taking externalRef from dependencies

motiondivision · May 12, 2021 · 2f6c163 · 2f6c163
1 parent 1d1eb5f
commit 2f6c163
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 Framer Motion adheres to [Semantic Versioning](http://semver.org/).
 
+## [4.1.16] 2021-05-12
+
+### Fixed
+
+-   Use with changing external refs.
+
 ## [4.1.15] 2021-05-11
 
 ### Fixed

diff --git a/src/motion/utils/use-motion-ref.ts b/src/motion/utils/use-motion-ref.ts
@@ -31,6 +31,11 @@ export function useMotionRef<Instance, RenderState>(
                 }
             }
         },
-        [visualElement, externalRef]
+        /**
+         * Only pass a new ref callback to React if we've received a visual element
+         * factory. Otherwise we'll be mounting/remounting every time externalRef
+         * or other dependencies change.
+         */
+        [visualElement]
     )
 }