You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I was wondering if I could contribute to the project by helping improve general code quality?
I picked this file in particular as a starting point because it seemed rather small and self-contained, but if you have other suggestions please feel free to let me know.
Here are some of the things I feel could be improved:
Use newtypes to enforce invariants present in comments here and here.
Try to improve readability of the numerous format! calls that embed other strings inside HTML fragments, probably by putting them in separate functions.
The text was updated successfully, but these errors were encountered:
You're more than welcome to contribute, please go right ahead and open a PR! A very large portion of Perseus is fairly haphazardly written because of how many times I've needed to change things to add new features. I18n in particular turned things into a bit of a pigsty. Any refactoring is appreciated, thank you very much!
I will be doing a major refactor soon to close #4, but that's a little while away.
Hi, I was wondering if I could contribute to the project by helping improve general code quality?
I picked this file in particular as a starting point because it seemed rather small and self-contained, but if you have other suggestions please feel free to let me know.
Here are some of the things I feel could be improved:
format!
calls that embed other strings inside HTML fragments, probably by putting them in separate functions.The text was updated successfully, but these errors were encountered: