Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watching should reload the browser #122

Closed
arctic-hen7 opened this issue Jan 20, 2022 · 3 comments
Closed

Watching should reload the browser #122

arctic-hen7 opened this issue Jan 20, 2022 · 3 comments
Labels
author-willing-to-impl The author of this issue is willing to try to implement the solution themselves. C-enhancement Category: enhancement tribble-reported This issue was reported through Tribble.

Comments

@arctic-hen7
Copy link
Member

This issue is requesting an enhancement to Perseus. Details of the scope will be available in issue labels.
The user described the problem related to this request as follows:

At the moment, Perseus' watching system can rebuild the app very effectively, but it doesn't reload the browser, which is inconvenient.

The user described the issue as follows:

When the -w/--watch flag is added to a supported CLI command, the CLI controller process should spawn an instructional server. Then, when we reload, that instructional server should be pushed a message ordering all listeners to reload. That server should be listened to over WebSocket by the app itself (through a feature flag to avoid unnecessary bloat, even though it's only in development). This could also be used to freeze the app's state as per #121 before a reload.

  • The author is willing to attempt an implementation: true
Tribble internal data

dHJpYmJsZS1yZXBvcnRlZCxDLWVuaGFuY2VtZW50LGF1dGhvci13aWxsaW5nLXRvLWltcGw=

@github-actions github-actions bot added author-willing-to-impl The author of this issue is willing to try to implement the solution themselves. C-enhancement Category: enhancement tribble-reported This issue was reported through Tribble. labels Jan 20, 2022
@arctic-hen7
Copy link
Member Author

Note that this requires a large amount of complex work, and probably won't be ready for quite a while yet.

@arctic-hen7
Copy link
Member Author

This is something like what we'll have to do here, for reference.

@arctic-hen7
Copy link
Member Author

Okay, the server is set up and working from the CLI, and the necessary information for connecting is being successfully passed to the client. Now it's just a matter of listening in the browser, and then this should be fully functional!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-willing-to-impl The author of this issue is willing to try to implement the solution themselves. C-enhancement Category: enhancement tribble-reported This issue was reported through Tribble.
Projects
None yet
Development

No branches or pull requests

1 participant