Typed options system #130
Merged
Typed options system #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have a way to display this yet, but there will soon be one.
This removes the need for the `define_app!` macro, and makes it dependent on this new system. There may be some minor changes needed to code using custom translations manager (which are now handled as futures).
This feature was originally present, and is now supported again!
This removes the dependency on an `index.html` file, all that is managed internally now! Note that this makes the old `index.html` file system dysfunctional, but I will fix that before this is merged.
This will all be ready after the index view system supports `index.html` sourcing.
This makes this entire update include no breaking changes (theoretically)!
This makes the engine entrypoint much more versatile.
|
There's a weird doc test failure in this that doesn't seem to make any sense whatsoever, so I'll debug that later. Otherwise, this is good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while now, people have requested a way to use Perseus without the
define_app!macro, and it is finally here! This PR brings an entirely new system of sending options to the Perseus engine, with greater flexibility for the future, a revamped index view system (removing any dependency onindex.html, you can now write that with Sycamore), and full backward compatibility withdefine_app!for existing apps.Notably, the old macro system now acts as a wrapper around the new, so, while I've tried to ensure full backward compatibility, there may be some minor changes needed in fringe use-cases.