Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<!DOCTYPE html> is printed two times. #154

Closed
afiqzx opened this issue Jun 23, 2022 · 4 comments
Closed

<!DOCTYPE html> is printed two times. #154

afiqzx opened this issue Jun 23, 2022 · 4 comments
Labels
C-bug Category: bug tribble-reported This issue was reported through Tribble.

Comments

@afiqzx
Copy link
Contributor

afiqzx commented Jun 23, 2022 •
edited
Loading

This issue is reporting a bug in the code of Perseus. Details of the scope will be available in issue labels.
The author described their issue as follows:

<!DOCTYPE html> is printed two times.

The steps to reproduce this issue are as follows:

  1. Download my repo: https://github.com/afiqzx/homepager
  1. build with perseus serve -w. (Maybe -w is unneded but I used it when the bug occured)
  2. Open the page in your browser.
  3. View source, and see <!DOCTYPE html> printed two times on top of the document.

A minimum reproducible example is available at https://github.com/afiqzx/homepager.

  • Hydration-related: false
  • The author is willing to attempt a fix: false (actually I will if given some pointers.)

Perseus version: 0.3.5
Sycamore version: 0.7

Tribble internal data

dHJpYmJsZS1yZXBvcnRlZCxDLWJ1Zw==
@github-actions github-actions bot added C-bug Category: bug tribble-reported This issue was reported through Tribble. labels Jun 23, 2022
@afiqzx
Copy link
Contributor Author

afiqzx commented Jun 23, 2022

double_doctype

Here is an example from my browser.

@arctic-hen7
Copy link
Member

I'm assuming you mean this repo instead, the one you linked to seems to contain configuration files.

@arctic-hen7
Copy link
Member

Thanks for the catch! This should be fixed now, it was just an extra doctype declaration written in the default HTML shell, which has now been removed. Much appreciated! (Note that this will be released in v0.4.0-beta.2, which should come out within 48 hours.)

@afiqzx
Copy link
Contributor Author

afiqzx commented Jun 23, 2022

Thank you for the response!
Understood. I will also test the beta when it comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug tribble-reported This issue was reported through Tribble.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afiqzx @arctic-hen7