-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant CLI improvements #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than `wasm-pack` This provides *significant* flexibility for all sorts of brilliant new features! BREAKING CHANGE: `[lib]`/`[[bin]]` settings no longer required in `Cargo.toml`, and `lib.rs` should be renamed to `main.rs` (everything is a binary now)
This cleans things up a little, and makes directory structures and cleaning build artifacts much simpler.
…ocally Perseus now has no dependencies except Rust! This also *dramatically* reduces bundle sizes for some reason (`wasm-pack` overhead?), by over 50kb in the basic example.
Since we now store `cargo` target directories inside `dist/`, they were being copied for exporting!
…see `perseus --help`)
This is more longwinded, but fixes a few priority issues, and it's much more maintainable and extensible.
This will be used preferentially over a local directory if available, minimizing wait times for creating new projects.
Our more advanced optimizations cut bundle sizes with Fluent *substantially*.
This will allow properly using the Cranelift backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the Perseus CLI much more user-friendly, and significantly more powerful, improving overall performance and usability.
wasm-pack
towasm-bindgen
for greater flexibilityCargo.toml
bloat)wasm-bindgen
andwasm-opt
intodist/
to prevent the user having to manage dependencies (but allows user override)wasm32-unknown-unknown
target ifrustup
is availableAfter this PR, users will need only one dependency on their systems to run Perseus: Rust itself. If they installed with
rustup
, everything will be automatic and speedy out-of-the-box, with full capacity for user overrides. Also, this PR achieves ~50kb bundle size reductions by switching towasm-bindgen
andwasm-opt
directly.Note: the Cranelift backend is experimental, and might be disabled by default, I haven't decided yet. (It does cut compile times by 75% though.)