Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support error page document metadata #176

Closed
arctic-hen7 opened this issue Aug 17, 2022 · 0 comments · Fixed by #179
Closed

Support error page document metadata #176

arctic-hen7 opened this issue Aug 17, 2022 · 0 comments · Fixed by #179
Labels
author-willing-to-impl The author of this issue is willing to try to implement the solution themselves. C-enhancement Category: enhancement tribble-reported This issue was reported through Tribble.

Comments

@arctic-hen7
Copy link
Member

This issue is requesting an enhancement to Perseus. Details of the scope will be available in issue labels.
The user described the problem related to this request as follows:

Right now, Perseus error pages can't do anything to the document <head>, which means landing on a page that's not found on an initial load gives no document title, and on a subsequent load, the previous page's metadata will be retained, which is terrible for accessibility, though apparently difficult for automated tests to detect, unfortunately.

The user described the issue as follows:

This should be easily fixed by allowing users to provide a static view! for the metadata error pages should render, which can be trivially interpolated in the same way pages have their metadata interpolated. The only potentially tricky thing might be getting this to work on the server side, though I think the functions are set up so that this should just be a one-spot change (theoretically). Either way, it should be easy to implement, though this would be a breaking change (fine for the next beta).

  • The author is willing to attempt an implementation: true
Tribble internal data

dHJpYmJsZS1yZXBvcnRlZCxDLWVuaGFuY2VtZW50LGF1dGhvci13aWxsaW5nLXRvLWltcGw=
@github-actions github-actions bot added author-willing-to-impl The author of this issue is willing to try to implement the solution themselves. C-enhancement Category: enhancement tribble-reported This issue was reported through Tribble. labels Aug 17, 2022
@arctic-hen7 arctic-hen7 mentioned this issue Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
author-willing-to-impl The author of this issue is willing to try to implement the solution themselves. C-enhancement Category: enhancement tribble-reported This issue was reported through Tribble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for error page heads framesurge/perseus
1 participant
@arctic-hen7