Substantial website improvements #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks *much* better! Nothing on the docs pages yet.
This fixes some of the styling bugs we were encountering.
Need to fill these in for each comparison still.
Also made the '100' emoji on the docs page green.
Did this work on a different device.
This includes pushing the footer to the bottom of the page.
Translations are now stored as JSON, and the bundle size has been reduced *dramatically*!
This now has dual-pane scrolling on desktop and a proper footer.
They're still quite long though, so I'll create some switchers for 'highlights'.
It doesn't do anything yet.
…e more digestable
There's an issue with the footer though...
It was due to my not updating the styles for the latest beta, which removed another wrapper `<div>`.
We probably don't need this `min-content`, but I feel slightly safer with it.
Pending indexing properly by DuckDuckGo etc.
This involved graying the header and making a filter-based light mode for the syntaxx highlighting (which triggers contrast ratio false-positives).
We can't fit the word 'internationalization' on there, so this is the next best thing.
We need to set up a proper sitemap first so that search engines can actually index everything.
This should be ready for deployment now!
|
This should be finally ready to merge now! The E2E tests are playing up a bit, and I'm not sure why, so I may need to re-run them a few times before this is actually merged. |
|
This has all worked and looks pretty good! The images are a little heavy though, so I'll make them more lightweight and fix that up this evening so they load more quickly. |
|
I've had to revert the deployment I'm afraid, due to a locale redirection bug that seems to only be affecting the website. I'm investigating further now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically redesigns the aesthetics of the Perseus website, as well as upgrading it to the latest beta version.