-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add instruction to replace perseus_integration #197
docs: add instruction to replace perseus_integration #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, I've been really busy lately! This looks great, just one minor wording thing I'd change, as I've noted.
examples/.base/src/main.rs
Outdated
|
||
/// Replace `<perseus_integration>` with an integration of your choice. | ||
/// Examples of supported integrations: | ||
/// - perseus_warp (use this one if you follow basic tutorials) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// - perseus_warp (use this one if you follow basic tutorials) | |
/// - perseus_warp (recommended) |
Requested change applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I completely forgot to actually merge this lol!
I didn't want to edit your in-depth explanation from the foldable pane, and without that, it would be kind of duplication, so instead, I opted to add a comment to the main.rs example. That way, if someone just copies the code, he'll have information right there, without the need to dig through the page.
I saw other integrations, so I added them, but maybe you don't want them exposed - let me know if you want some tweaking on this.