Turn #[make_rx] into #[derive(ReactiveState)]
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No tests will pass right now!
Also fixed a few typos that had accumulated recently, mostly in the state platform docs.
|
Note that the name of the reactive version of state is now specified with the |
|
CI appears to be broken at the moment. Along with #238, I am merging this without test validation, and any errors will be sorted out in a separate PR. (I'll try to fix CI on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the attribute macro
#[make_rx]and replaces it entirely with#[derive(ReactiveState)], which achieves the exact same ends, using a derive macro. This allows for more sensible placement of the#[rx(nested)]helper macro over nested fields, while also matching neatly with the newUnreactiveStatederive macro. Overall, this contributes to improved ergonomics.This of course involves several breaking changes.