Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a space after the URL when serve is done #24

Closed
Mazwak opened this issue Sep 24, 2021 · 3 comments
Closed

Add a space after the URL when serve is done #24

Mazwak opened this issue Sep 24, 2021 · 3 comments
Assignees
Labels
A-cli Area: command line interface C-bug Category: bug D-easy Difficulty: easy good first issue Good for newcomers P-high Priority: high S-in-development Status: in development

Comments

@Mazwak
Copy link
Contributor

Mazwak commented Sep 24, 2021

Is your feature request related to a problem? Please describe.

When perseus serve finishes, the message presents the URL immediately followed by an exclamation mark.
VSCode parses the line and finds the URL but it includes the exclamation.

Describe the solution you'd like

Put a space between the URL and the exclamation mark.

Describe alternatives you've considered

The URL could be surrounded by brackets or parenthesis or …
The VSCode parser could be improved, but there might be a lot of parser not detecting the URL correctly

@arctic-hen7 arctic-hen7 self-assigned this Sep 24, 2021
@arctic-hen7 arctic-hen7 added A-cli Area: command line interface C-bug Category: bug D-easy Difficulty: easy good first issue Good for newcomers P-high Priority: high S-in-development Status: in development labels Sep 24, 2021
@arctic-hen7
Copy link
Member

arctic-hen7 commented Sep 24, 2021

Interestingly, I'm pretty certain that there's no case in which a URL could even have an unparsed exclamation mark in it, so I'll consider taking this up with VS Code as well. That said, and immediate solution is needed, and just surrounding it with angular brackets works quite well.

@arctic-hen7
Copy link
Member

Hilariously, VS Code's parser works for a full stop (legal in URLs), but not for an exclamation mark (illegal in URLs). Nonetheless, angular brackets are now added, and this will be released with static exporting and HTTP response modification in v0.2.2 this afternoon.

@Mazwak
Copy link
Contributor Author

Mazwak commented Nov 3, 2021

Thanks for the workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: command line interface C-bug Category: bug D-easy Difficulty: easy good first issue Good for newcomers P-high Priority: high S-in-development Status: in development
Projects
None yet
Development

No branches or pull requests

2 participants