Refactor errors (breaking) #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error reporting is now much nicer.
Was `FetchError`, should be `ClientError`.
We don't need `anyhow` anymore.
Before, only `String` was allowed as an error type. This also makes `?` usable. BREAKING CHANGE: `StringResult`/`StringResultWithCause` are replaced by `RenderFnResult`/`RenderFnResultWithCause`
We're now using JS raw strings, escaping as necessary, and then escaping control characters in the shell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors errors to use
thiserrorandfmterrinstead oferror_chain, and additionally improves render functions to work with any error messages, making?possible in them. This includes breaking changes, and will be released in v0.3.0.Closes #31.