Create parent directories with CLI #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This *should* fix #69, but we'll see.
This should make compiling for obscure Docker environments *far* easier while fixing!
These were only for testing in Docker, and they're no longer required.
arctic-hen7
added
C-bug
|
Tests are failing because of an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes an internal function in the CLI that's responsible for cleaning up old build artifacts. However, if the
dist/directory doesn't exist, it would fail. This PR fixes that by usingcreate_dir_all.Note that the error that spawned this fix was only reproducible in Docker (see #69), though this will likely fix a number of other possible issues with directory corruption and working with the
.perseus/directories in this repo.