Add Warp integration #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make developing more integrations in future much simpler. This also involved standardizing the `Options` taken by all integrations BREAKING CHANGE: `Options` renamed to `ServerOptions` for all integrations
This involved adding an atomic types system. Also added basics for a Warp integration (which needs this thread-safety).
The problem is `Rc<Translator>`s, so some refactoring needs to be done.
BREAKING_CHANGE: `ServerOptions` now only accepts one static content directory
None of this has been tested yet, so there will likely be bugs. We now depend on my fork of Warp until [this](seanmonstar/warp#924) is merged.
Fixes #85.
It's also now the default in the CLI.
Now covers the `Cargo.toml` files in `examples/basic/.perseus`.
|
Okay, all E2E tests have failed because of an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Warp integration and makes Perseus thread-safe for server-side usage, which should make developing server integrations for platforms other than Actix Web much easier. This also includes a fix for #85.
Notably, this removes support for multiple static directories, because that would've involved significant gymnastics with Warp. At present, some gymnastics are required to support static aliases, and so Perseus will use my fork of Warp for now (PR pending).
Also, this makes Warp the default integration for when v0.3.x goes stable (more details to come on the reasoning for this).