-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PERSEUS_STANDALONE
#87
Comments
If you have no need to do |
I know, but I'm pretty sure this can all be done with features, so I'm working on that at the moment to make things more convenient. |
Heh, ok. I guess maybe it's too much trouble to weed out I remember having trouble with figuring out I need to set Is |
Yes, Warp is now used for everything (not explicitly clear in the docs, but mentioned in the CHANGELOG). Yes, Also, @phaleth are you still planning to write a page in the docs on using Perseus with Docker? I think it'd be a great addition and given the sheer amount of work you've done with the two together I think you'd be the best person to write it! |
I still do plan to document Perseus deployment with Docker. Actually, sorry about hijacking this issue, but thanks for bringing that up. So far I didn't even manage to figure out how to contribute to Perseus, cause I'm not done with the deployment story yet. In short the next thing I need is to figure out how to transpile out the dynamic JS What consumes my time lately is figuring out the basics of how Anyway, @arctic-hen7, since this issue has been hijacked, the main question I have for you about Perseus is that: Do you think now that |
The |
@phaleth that Also, on hot reload, yes. As I've said on Discord, that will be my priority for v0.3.1. Thank you for reminding me about this though, this is tracked now by #90. |
@arctic-hen7, alright, yeah, thank you. Hot reload will be great and don't worry about HMR, rust code takes a while to compile anyways.
|
Great! I'm going to go ahead and include that in the optimizations docs then! Thanks! |
Is your feature request related to a problem? Please describe.
I just spent 10 minutes trying to figure out why deployment had failed, only to realize that I hadn't provided
PERSEUS_STANDALONE=true
, and I built this project. If I'm having trouble remembering that this environment variable needs to be provided, it's probably an issue!Describe the solution you'd like
The
PERSEUS_STANDALONE
environment variable should be removed in favor of some other method of telling Perseus that it's been deployed. My initial instinct is to have a feature on the crates that need it that gets enabled at the command-line level when we deploy, otherwise maybe something with build scripts might work.Describe alternatives you've considered
Continuing to use the environment variable, but I think it's a pain point and an unnecessary requirement.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: