Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected item colour in listboxes and popups incorrect on Mac #115

Closed
SamSandq opened this issue Mar 18, 2024 · 2 comments
Closed

Selected item colour in listboxes and popups incorrect on Mac #115

SamSandq opened this issue Mar 18, 2024 · 2 comments
Assignees

Comments

@SamSandq
Copy link

SamSandq commented Mar 18, 2024

The selected item's colour is not according to Apple standard.

In osglobals.m: i_theme_colors, line 109, you have

oscolor_NSColor_rgba_v([NSColor selectedControlColor], i_SELBG_COLOR);

which shows up, in a listbox, like this:

Screenshot 2024-03-18 at 14 48 11

Instead, the line should read:

oscolor_NSColor_rgba_v([NSColor selectedContentBackgroundColor], i_SELBG_COLOR);

which shows the Mac standard colour:

Screenshot 2024-03-18 at 14 47 14

This makes the highlighted / selected lines in popups and listboxes follow all other applications on the Mac. It also applies to tableviews, where it may not be wanted. I suggest making these user-configurable to cater for all needs.

@frang75 frang75 self-assigned this Mar 19, 2024
@SamSandq
Copy link
Author

I made a slight mistake above: popups are standard mac controls, and use the correct colour, like combo boxes too. The listbox and tables are NAppGUI implementations, and sometimes do not follow standard usage (at least on the Mac)

@frang75
Copy link
Owner

frang75 commented Apr 4, 2024

You're right. From macOS Mojave, Apple provide a more convenient selection color . Fixed here 7485964

@frang75 frang75 closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants