-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary files in the source code #22
Comments
Hi @hippie68! https://nappgui.com/en/start/resources.html You have the NRC source code at: https://github.com/frang75/nappgui_src/tree/main/src/utils If you want to use NAppGUI avoiding precompiled binaries you can follow these steps:
I find your observation interesting. I will include in the official documentation these steps, so that the user can generate the NRC locally. I will also check the viruses you mention. The binaries go directly from my CI to GitHub, they do not go through any intermediary service (hosting, etc). Regards and enjoy NAppGUI |
Related issue #44. Expected to change in future releases. |
Hi @hippie68 ! In next NAppGUI release (1.4), the 'nrc' will be compiled in CMake generate process. All precompiled binaries will be removed. |
Hi, shouldn't it be: include(${ROOT_PATH}/prj/CMakeNAppGUI.cmake) instead of include(${ROOT_PATH}/prj/CMakeNAppGUI.txt) ??? |
NAppGUI 1.4 has removed all binary files from repo. |
A lot of effort seems to have put into this project. I looks interesting and I would like to try it out, however when looking at the source code, I found binary files for various operating systems in subdirectories of the directory "prj". E.g. "prj/script/win/x64/nrc.exe", a file which even got 2 warnings when analyzing it via virustotal.com. I admit some false positives are normal. I want to trust the project, however I don't know why those binary files are there nor what they do, and why they need to be there in binary form instead of source code. Could you clarify it? Would it be possible to provide the source code? I am concerned about running binary files of unknown origin. Thanks for understanding.
The text was updated successfully, but these errors were encountered: