Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will break with gnome-shell 3.30 #93

Open
eddy-geek opened this issue Sep 1, 2018 · 7 comments
Open

Will break with gnome-shell 3.30 #93

eddy-geek opened this issue Sep 1, 2018 · 7 comments

Comments

@eddy-geek
Copy link

eddy-geek commented Sep 1, 2018

Extension does not start on Fedora 29 Beta, gnome-shell 3.30 RC (3.29.91-1)

Current Behavior

Following errors are printed:

TypeError: global.screen is undefined
appMenu is null
TypeError: global.screen is undefined

Possible Solution

See home-sweet-gnome/dash-to-panel#434 and fix micheleg/dash-to-dock#770

Basically global.screen moved to global.display, while all the workspace related features have been moved to the WorkspaceManager and displays are managed by DisplayManager.

Also the built-in extensions update commit

Your Environment

  • gnome-shell version: 3.29.91-1
  • distribution : Fedora 29 Beta
@eddy-geek
Copy link
Author

Actually the work for this has been done already. I can confirm git master works with 3.29.91.

What is missing is the update of the official gnome-shell store.

@uniquePWD
Copy link
Contributor

Has this been uploaded to Gnome Extensions, there's apparently nothing waiting in the review queue for this.

@aspidxt
Copy link

aspidxt commented Oct 16, 2018

  • 1, crashes on GNOME Shell 3.30.1
    gnome-shell[22270]: Extension "no-title-bar@franglais125.gmail.com" had error: TypeError: global.screen is undefined

@uniquePWD
Copy link
Contributor

Hopefully @trustin can make a pull request with the changes he proposed in #97 so they can merged.

@trustin
Copy link

trustin commented Oct 16, 2018

I release the diff I published in #97 under public domain as defined in https://creativecommons.org/publicdomain/zero/1.0/deed.en

Please feel free to take it and do whatever you wanna do, e.g. sending a new PR or merging it into your repository.

@uniquePWD
Copy link
Contributor

Done. Thank you @trustin

@uniquePWD
Copy link
Contributor

Does anyone know what @franglais125 is planning to do with this extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants