New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #315 causes exception when name not provided #320

Closed

jmrossy opened this issue Dec 19, 2020 · 1 comment

jmrossy commented Dec 19, 2020

Expected Behaviour

No exception when name is left null/undefined

Actual Behaviour

Exception is thrown.
The issue is with this line which was modified in the last release:
https://github.com/frappe/charts/pull/315/files#diff-5fae7e3027fe415c8929935437f5b31e266fddc2b776cd2df8210f4f51f3512fR113

Steps to Reproduce:

Create a chart with a dataset that has no name
Exception is thrown due to attempt to call replace on undefined

Frappé Charts version: v1.5.5

Contributor

scmmishra commented Dec 22, 2020

Released a fix for this https://github.com/frappe/charts/releases/tag/v1.5.6

scmmishra closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment