Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete processing of supplier quotations upon submit by the supplier from the supplier portal #37531

Closed
GichanaMayaka opened this issue Oct 16, 2023 · 1 comment
Labels

Comments

@GichanaMayaka
Copy link

GichanaMayaka commented Oct 16, 2023

Information about bug

I'm having trouble when suppliers submit their quotations from the portal. Upon receiving an email asking them to quote their prices, they populate the rates field then when they submit, they receive a modal with the title "Message" and nothing else, as below:.
SQ Submit
The dev tools do not display any error message indicating that no exception/error is being thrown/raised. The submitted supplier quotation does not register as a record in the database either.

It should be noted that there is a customised application (https://github.com/navariltd/navari_rfq_opening) that does some validation and processing before sending the email to suppliers to quote their prices. The error on submission happens whether the application's override whitelisted method is called, or the system's default implementation is called. Having said that, the issue still persists even without any custom application installed. It should also be noted that the issue resolves when giving the supplier additional permissions - Purchase User in this case - but this has the caveat that the supplier can access information they should not be privy to via the "Switch to Desk" option in the supplier portal.

Module

buying

Version

Frappe Version: 15.0.0-dev
ERPNext Version: 15.0.0-dev

Installation method

FrappeCloud

Relevant log output / Stack trace / Full Error Message.

No response

@muchai
Copy link

muchai commented Oct 23, 2023

@rohitwaghchaure Despite the updates, the error occurs if the supplier has an address attached to them.
image
Solution is to grant All to Address doctype.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants