Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded videos in post does not play #310

Open
kramteo opened this issue Aug 27, 2024 · 1 comment
Open

Uploaded videos in post does not play #310

kramteo opened this issue Aug 27, 2024 · 1 comment
Assignees

Comments

@kramteo
Copy link

kramteo commented Aug 27, 2024

I have uploaded a video in posts (MP4 file). However, there is no way to play the video when viewing the post.

I have tried to double-click on the video and also move cursor around, but cannot activate the video.

I suppose since videos can be uploaded, there must be able to be played.

I am on Gameplan: v0.0.1 (HEAD) / Frappe Framework: v15.39.0 (HEAD)

Appreciate any advice on my issue. Thanks!

Screenshot 2024-08-27 144441

@uhrjun
Copy link
Member

uhrjun commented Aug 31, 2024

Valid issue, currently you can't play any videos in pages. Videos are only playable when the document is not editable inside an editor. That only happens when a user makes a post in Gameplan, so the video becomes playable.

Can't do the same with pages currently, since a page is never "published" it's always
editable. Will update to fix this.

Cause:
https://github.com/frappe/frappe-ui/blob/4f168d8a7ce0a93b1560c902d8907a7ff4ea4af4/src/components/TextEditor/video-extension.js#L39-L41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants