fix(factories): Add remainder of html string to finalHtml

Author: Dan Nguyen

dist/textAngular-rangy.min.js

@@ -237,6 +237,7 @@ angular.module('textAngular.factories', [])
 			finalHtml += html.substring(lastIndex, match.index) + appleSpaceVal;
 			lastIndex = match.index + match[0].length;
 		}
+		finalHtml += html.substring(lastIndex);
 		/* istanbul ignore next: apple-contereted-space span has matched */
 		if (lastIndex) {
 			// modified....
@@ -2752,6 +2753,25 @@ textAngular.directive("textAngular", [
 				scope.displayElements.text.on('keyup', _keyup);
 				// stop updating on key up and update the display/model
 				_keypress = function(event, eventData){
+					// bug fix for Firefox.  If we are selecting a <a> already, any characters will
+					// be added within the <a> which is bad!
+					var _selection = taSelection.getSelection();
+					/* istanbul ignore next: don't see how to test this... */
+					if (taSelection.getSelectionElement().tagName.toLowerCase() === 'a') {
+						// check and see if we are at the edge of the <a>
+						if (_selection.start.element.nodeType === 3 &&
+							_selection.start.element.textContent.length === _selection.end.offset) {
+							// we are at the end of the <a>!!!
+							// so move the selection to after the <a>!!
+							taSelection.setSelectionAfterElement(taSelection.getSelectionElement());
+						}
+						if (_selection.start.element.nodeType === 3 &&
+							_selection.start.offset === 0) {
+							// we are at the start of the <a>!!!
+							// so move the selection before the <a>!!
+							taSelection.setSelectionBeforeElement(taSelection.getSelectionElement());
+						}
+					}
 					/* istanbul ignore else: this is for catching the jqLite testing*/
 					if(eventData) angular.extend(event, eventData);
 					scope.$apply(function(){

dist/textAngular.js

@@ -1133,6 +1133,7 @@ angular.module('textAngular.factories', [])
 			finalHtml += html.substring(lastIndex, match.index) + appleSpaceVal;
 			lastIndex = match.index + match[0].length;
 		}
+		finalHtml += html.substring(lastIndex);
 		/* istanbul ignore next: apple-contereted-space span has matched */
 		if (lastIndex) {
 			// modified....
@@ -3648,6 +3649,25 @@ textAngular.directive("textAngular", [
 				scope.displayElements.text.on('keyup', _keyup);
 				// stop updating on key up and update the display/model
 				_keypress = function(event, eventData){
+					// bug fix for Firefox.  If we are selecting a <a> already, any characters will
+					// be added within the <a> which is bad!
+					var _selection = taSelection.getSelection();
+					/* istanbul ignore next: don't see how to test this... */
+					if (taSelection.getSelectionElement().tagName.toLowerCase() === 'a') {
+						// check and see if we are at the edge of the <a>
+						if (_selection.start.element.nodeType === 3 &&
+							_selection.start.element.textContent.length === _selection.end.offset) {
+							// we are at the end of the <a>!!!
+							// so move the selection to after the <a>!!
+							taSelection.setSelectionAfterElement(taSelection.getSelectionElement());
+						}
+						if (_selection.start.element.nodeType === 3 &&
+							_selection.start.offset === 0) {
+							// we are at the start of the <a>!!!
+							// so move the selection before the <a>!!
+							taSelection.setSelectionBeforeElement(taSelection.getSelectionElement());
+						}
+					}
 					/* istanbul ignore else: this is for catching the jqLite testing*/
 					if(eventData) angular.extend(event, eventData);
 					scope.$apply(function(){

dist/textAngular.min.js

@@ -47,6 +47,7 @@ angular.module('textAngular.factories', [])
 			finalHtml += html.substring(lastIndex, match.index) + appleSpaceVal;
 			lastIndex = match.index + match[0].length;
 		}
+		finalHtml += html.substring(lastIndex);
 		/* istanbul ignore next: apple-contereted-space span has matched */
 		if (lastIndex) {
 			// modified....