Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account



		 #307

Closed
djskinner opened this issue Sep 8, 2014 · 8 comments
Closed



		 #307

djskinner opened this issue Sep 8, 2014 · 8 comments
Labels

Comments

@djskinner
Copy link

Seems that when I edit the HTML I end up with really messy code including lots of these: 

		

You can reproduce this on the home page by editing the HTML and pressing the return key a few times. Is there a way to stop it HTML encoding preformatting such as line breaks, spaces and tabs in this way?

@SimeonC
Copy link
Collaborator

SimeonC commented Sep 8, 2014

Yea, that's not ideal. No there isn't any way of doing that I can think of off the top of my head, we haven't really done much with the html edit mode as such. I'll keep it on the list if we ever get all the big bugs and features done but you're probably better off implementing an external HTML editor like ui-codemirror (see #104).

@SimeonC
Copy link
Collaborator

SimeonC commented Sep 16, 2014

I noticed this also causes issues when pasting, I've edited the sanitizer to remove these unicode characters. I'm not sure it's the best solution but I think it's better nothing. Turns out that this unicode formatting was occurring in the original angular-sanitize code which for our case is rather odd. Not sure if that fixes your problem but it's in the new pre-release if you care to test it out.

@geyang
Copy link
Collaborator

geyang commented Sep 16, 2014

Hey @SimeonC ,

I just want to check with you: when you remove these unicode, does it affect the line breaks we put into <pre> blocks?

@SimeonC
Copy link
Collaborator

SimeonC commented Sep 16, 2014

Ah... Yes, it does. I didn't know it treated them differently, I'll revert that particular piece of code.

@geyang
Copy link
Collaborator

geyang commented Sep 16, 2014

(^_^)

@geyang
Copy link
Collaborator

geyang commented Oct 2, 2014

Hi @SimeonC ,

I just noticed that the v1.3.0-pre1 still have this commit included, which makes code snippets inside pre tag collapse into a single line. (end of line escaped character removed).

@geyang
Copy link
Collaborator

geyang commented Oct 3, 2014

okay this is reverted in v1.3.0-pre2. Thanks @SimeonC !

@SimeonC SimeonC removed the wontfix label Jan 21, 2015
@SimeonC
Copy link
Collaborator

SimeonC commented Jan 21, 2015

I suddenly realised there is a good use for doing this properly, so it is done correctly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants