Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCE Authentication #316

Closed
rgammans opened this issue Sep 13, 2021 · 5 comments · Fixed by #325
Closed

PKCE Authentication #316

rgammans opened this issue Sep 13, 2021 · 5 comments · Fixed by #325

Comments

@rgammans
Copy link
Contributor

I've written a PoC PKCE implementation. This works with my small use case, but is there any demand to get this tidied up and integrated into the rest of the library?

PoC Here: https://gist.github.com/rgammans/af01ec49c850334a91eae51c44d30583

@freakboy3742
Copy link
Owner

If there's an authentication mode that Xero supports, we'd definitely like to support it.

@jeremyherbert
Copy link

Thank you! This works great!

@rgammans
Copy link
Contributor Author

What do you need to be included in a PR for this? Currently, I've not got any tests, and there is no final 'success' page presented to the browser.

@freakboy3742
Copy link
Owner

@rgammans Tests are definitely a requirement; documentation would also be an important piece - especially if the implementation is missing an important "final step" that the user will need to implement.

@rgammans
Copy link
Contributor Author

I'll add this to my TODO list, but I've got some unrelated work that is going to have to take priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants