-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKCE Authentication #316
Comments
If there's an authentication mode that Xero supports, we'd definitely like to support it. |
Thank you! This works great! |
What do you need to be included in a PR for this? Currently, I've not got any tests, and there is no final 'success' page presented to the browser. |
@rgammans Tests are definitely a requirement; documentation would also be an important piece - especially if the implementation is missing an important "final step" that the user will need to implement. |
I'll add this to my TODO list, but I've got some unrelated work that is going to have to take priority. |
I've written a PoC PKCE implementation. This works with my small use case, but is there any demand to get this tidied up and integrated into the rest of the library?
PoC Here: https://gist.github.com/rgammans/af01ec49c850334a91eae51c44d30583
The text was updated successfully, but these errors were encountered: