Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version in Description #22

Open
StevenXL opened this issue May 23, 2024 · 1 comment
Open

Version in Description #22

StevenXL opened this issue May 23, 2024 · 1 comment

Comments

@StevenXL
Copy link

When the action runs, it outputs a version. The version that it outputs is the version of GHC that the action detected, not the version of weeder being used.

Is this intentional? I was expecting the version to be the version of weeder itself:

image

@StevenXL StevenXL changed the title Description of Weeder Version Version in Description May 23, 2024
@pbrisbin
Copy link
Member

pbrisbin commented Aug 27, 2024

It is expected, but I see how it's misleading.

Weeder must be built with the same version of GHC as the project you intend to run it on. This means that the same weeder version (say, 2.7.0) must be built multiple times with different GHCs (say 9.4.5 and 9.4.7). For this reason, the built binaries are named by GHC version (weeder-9.4.5 and weeder-9.4.7), not weeder version (which would be weeder-2.7.0 for both).

We could experiment with ways to clarify this. Maybe call them weeder-{weeder-version}-ghc{ghc-version}, so weeder-2.7.0-ghc9.4.5, or something. I don't know that it's worth it, but feel free to tackle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants