Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state-reproducibility-flush test ignores CLAP_PARAM_IS_READONLY #15

Open
falkTX opened this issue Sep 29, 2023 · 2 comments
Open

state-reproducibility-flush test ignores CLAP_PARAM_IS_READONLY #15

falkTX opened this issue Sep 29, 2023 · 2 comments

Comments

@falkTX
Copy link

falkTX commented Sep 29, 2023

I have a plugin that only has "output" style parameters, basically pure metering that is exposed to the host with the parameter flags set as CLAP_PARAM_IS_READONLY

The validator tool fails to take this into account and tries to set values for these parameters, even though they are marked as read-only.

@robbert-vdh
Copy link
Member

Only parameters marked as CLAP_PARAM_IS_AUTOMATABLE are considered in these tests. So it sounds like the parameter in question has both the CLAP_PARAM_IS_AUTOMATABLE and CLAP_PARAM_IS_READONLY flags set. Since even without CLAP_PARAM_IS_AUTOMATABLE parameters can still be changed by the host as a result of live user input, I'll change the filter to allow any non-hidden and non-readonly parameter to be randomized, as opposed to only randomizing automatable parameters. I'll also add a check that disallows parameters that have both CLAP_PARAM_IS_READONLY and CLAP_PARAM_IS_AUTOMATABLE/CLAP_PARAM_IS_MODULATABLE, as that is obviously an error on the plugin's side.

Can you try again with the latest master branch version?

@falkTX
Copy link
Author

falkTX commented Oct 17, 2023

Hi, any chance for a rebuild or CI fixup? I do not have a rust compiler setup here, was hoping to test it with the GH actions but latest build failed (due to using deprecated 18.04 as base)

I did check on my side btw, and I am not using CLAP_PARAM_IS_AUTOMATABLE together with CLAP_PARAM_IS_READONLY, they are mutually exclusive on DPF side. The validation issue was all about the host changing params marked as read-only, which I believe it is fixed now but cannot test at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants